search

coreos / issue-sync

A tool for synchronizing issue tracking between GitHub and JIRA
Apache License 2.0
124 stars 34 forks source link

Create API client objects #15

Closed MorganEPatch closed 7 years ago

MorganEPatch commented 7 years ago

Depends on #14.

Group the GitHub and JIRA functions into client API objects which wrap the library APIs. This hides the details of the GitHub and JIRA APIs from the rest of the library, and allows us to create multiple clients for dry runs and test mocking.

@squat

MorganEPatch commented 7 years ago

This isn't ready for review yet. I've been testing with dry runs, which do work just fine here, but there seems to be a bug causing crashes when run for real.

squat commented 7 years ago

@LyonesGamer Ok. Please let me know if you need a hand. I would be happy to help you debug.

MorganEPatch commented 7 years ago

@squat Should be fixed now. The issue is that the endpoints to create or update a JIRA issue return an issue object, but I didn't realize that object only has the key and ID set. So I need to call GET after a create or update in order to have the complete issue object.