coreos / issue-sync

A tool for synchronizing issue tracking between GitHub and JIRA
Apache License 2.0
124 stars 34 forks source link

Comment regular expression is fragile #29

Open ripla opened 6 years ago

ripla commented 6 years ago

In some comments in our repository the comments regexp in comments.go fails to match at all, and sync fails since fields is empty.

As a ugly quickfix I had to add

if len(fields) != 5 {
        log.Debug("Failed to update JIRA comment for ", jIssue.ID)
        return nil
    }

To UpdateComment to make sync work. Also writing the config to home failed on macOS, but worked when I specified a full file path. I can add a separate issue about that if needed.