search

coreos / issue-sync

A tool for synchronizing issue tracking between GitHub and JIRA
Apache License 2.0
124 stars 34 forks source link

update all dependencies #46

Open crfeliz opened 5 years ago

crfeliz commented 5 years ago

45

Update all dependencies. Add .idea and issue-sync (output of go build) to .gitignore. Specify int64 where necessary.

crfeliz commented 5 years ago

@squat I know this is quit a large change set. What it boils down to is running a glide upgrade and changing int to int64 in a few places. Could you offer some guidance on how to get this upgrade approved for upstream? I have a few other feature-based changes I hope to push up as well however this upgrade is prerequisite.

crfeliz commented 5 years ago

Bumping this issue. Let me know if there is anything I can do to to get this change review/merged. I know i looks daunting but this is pretty much the result of running glide update and then fixing the few errors int64 related errors. If you have a preferred plan of action for updating dependencies I'd be happy to follow that process.

squat commented 5 years ago

Hmm that’s too bad yes let’s plz tackle that.

On Friday, May 10, 2019, Carlos R. Feliz notifications@github.com wrote:

@crfeliz commented on this pull request.

In .gitignore https://github.com/coreos/issue-sync/pull/46#discussion_r283045089:

@@ -14,3 +14,5 @@ .glide/

bin/ +.idea/ +issue-sync

yea it currently builds in the same directory as source. I can look into that. I'll remove this from the pr.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/coreos/issue-sync/pull/46#discussion_r283045089, or mute the thread https://github.com/notifications/unsubscribe-auth/AE4JAP2H6NMPGPIMYI225JLPUXQWRANCNFSM4HHSQP2Q .