coreos / layering-examples

Apache License 2.0
111 stars 24 forks source link

generate-rhcos-versions: Only inject `ADD rhel.repo` if needed #26

Closed cgwalters closed 2 years ago

cgwalters commented 2 years ago

generate-rhcos-versions: s/file/name/

file is a builtin Python keyword, we shouldn't override it.


generate-rhcos-versions: De-indent loop

It's more readable this way.


generate-rhcos-versions: Only inject ADD rhel.repo if needed

Only some of the examples actually install packages, not all. In particular the selinux one does not, and I want to use it as a test case to fix https://github.com/openshift/os/issues/829

I'm thinking actually we should drop this bit entirely and rely on host subscriptions or users doing it on their own, but for now this works.