search

coreos / mayday

A diagnostics tool for capturing system state.
Apache License 2.0
81 stars 27 forks source link

Implement more rigorous testing #26

Open brianredbeard opened 8 years ago

brianredbeard commented 8 years ago

We should implement functional and unit testing for Mayday.

As we progress in adding features (Object storage upload, etc) we should strive for 100% test coverage.

tschuy commented 8 years ago

27 has a bunch of setup for getting testing done, and contains tests for file.go and command.go.

Can you explain more about what we're looking for the (specific tests you pointed out) to do? For instance, for "symbolic link naming", is that just making sure that if I say to run tar -xzf foo.tar.gz and make a link called "foo", that the link foo is made to mayday_commands/tar_-xzf_foo.tar.gz ? And for the functional tests, these are tests on the output files in /tmp/, correct?

tschuy commented 8 years ago

Ok, I rewrote Mayday. See #29. It's a heck of a lot more testable, but there are certain aspects I'm not sure of.