add rkt pod listing support

coreos / mayday

A diagnostics tool for capturing system state.

Apache License 2.0

80 stars 27 forks source link

add rkt pod listing support #31

Closed tschuy closed 8 years ago

tschuy commented 8 years ago

Uses the rkt api, instead of trying to parse the output of rkt list --full, which means it's a lot nicer (except pulling in half of san francisco as a dependency).

tschuy commented 8 years ago

How would the "safe" pod be identified to mayday? Would we be best served by having a `pods: ["uuid1", "uuid2"]" section in our config? Set it on the CLI? (Neither of these seem particularly scalable/easy for the end user.) Collect from certain apps/when pods are running images from a given list (either in config, or hard coded, or passed as an arg/env variable)?

tschuy commented 8 years ago

For config -- replacing flag, and changing behavior based on --danger -- I think perhaps something like viper might be better. It supports getting config vars from flags using pflags, and it might be possible to replace our config parsing logic with its logic. I'll try it out.

tschuy commented 8 years ago

I've not yet moved the --danger flag, but other than that, this should be mostly good to go.

tschuy commented 8 years ago

Handy links for the diffs, skipping the vendor stuff: https://github.com/coreos/mayday/compare/ab64c55...6e3fa35 https://github.com/coreos/mayday/compare/05cd475...44ad3a4

tschuy commented 8 years ago

And I've also gotten docker support in there (https://github.com/tschuy/mayday/commit/ccc0f2889ceeaa81ecb616d7567309d24fcbff55) but we'll leave that for another PR :stuck_out_tongue_winking_eye:

brianredbeard commented 8 years ago

LGTM.