Sort keys within Docker configuration with `--danger` operation

coreos / mayday

A diagnostics tool for capturing system state.

Apache License 2.0

80 stars 27 forks source link

Sort keys within Docker configuration with `--danger` operation #38

Closed brianredbeard closed 8 years ago

brianredbeard commented 8 years ago

There is a (accidental?) key sorting which occurs when pulling in the docker configuration when not running in --danger mode. This has the side effect of making it easier to identify information in the json output.

It would be desirable to sort these keys in danger mode as well to make it easier to read the output.

brianredbeard commented 8 years ago

Affects https://github.com/coreos/mayday/pull/32

tschuy commented 8 years ago

Ok, that's easy.

The reason I wasn't doing this before is because I was able to keep from making a copy of the file in memory, which felt reasonable. But I think the benefits of pretty print outweigh the cost of keeping a file in memory.

tschuy commented 8 years ago

Fixed in #32.