coreos / mayday

A diagnostics tool for capturing system state.
Apache License 2.0
80 stars 27 forks source link

Make things more plugin-y #43

Closed tschuy closed 8 years ago

tschuy commented 8 years ago

This makes things more plugin-y -- every "plugin" (commands, journals, rkt, files, etc) gets its own package in the mayday/mayday/plugins directory. it implements tarable, optionally using tarable.Header() to do so (not automatically, but as a helper function).

Current downsides:

  1. files are copied into memory when loaded, before anything else is run, and not when they're being copied in, which means memory usage
  2. because I'm having some problems with how my buffers are working. I'm pretty sure I can get this fixed fairly simply though.
  3. we still can't configure these plugins by config files, but that's next (and for another PR).
brianredbeard commented 8 years ago

LGTM

LGTM