search

coreos / pkg

a collection of go utility packages
Apache License 2.0
188 stars 70 forks source link

capnslog: implement logrus.StdLogger #81

Closed squat closed 7 years ago

squat commented 7 years ago

This commit adds a Panicln method to the PackageLogger to make it implement all of the golang/log logging methods and thus making it implement with the logrus.StdLogger interface. I want this so that Dex can accept loggers from packages that use capnslog, notably bridge. This is the only missing method to fulfil the interface.

lucab commented 7 years ago

I'm merging this, but capnslog is still on a deprecation path. @squat can you please open an issue against bridge (or whatever else you are stepping in) to suggest moving to logrus or other alternatives?

squat commented 7 years ago

@lucab thanks. And yes, this is a stopgap until we can port the libraries to use logrus/other logging lib