search

coreos / tectonic-docs

Tectonic documentation - https://coreos.com/tectonic/docs/latest/
Apache License 2.0
42 stars 49 forks source link

docs: add missing permission #105

Closed cpanato closed 6 years ago

cpanato commented 6 years ago

fixes: https://github.com/coreos/bugs/issues/2266 and INST-714

sym3tri commented 6 years ago

@cpanato LGTM But can you link to the PR that introduced the change?

cpanato commented 6 years ago

This PR introduced the changes: https://github.com/coreos/tectonic-installer/pull/2362

cc @sym3tri

sym3tri commented 6 years ago

@cpanato are you sure? I don't see ListRoles in the diff.

cpanato commented 6 years ago

@sym3tri sorry it came from here: https://github.com/coreos/bugs/issues/2266

sym3tri commented 6 years ago

@cpanato that's just the request to add it. Is there someplace recently that added that permission as a requirement?

Maybe @s-urbaniak knows?

s-urbaniak commented 6 years ago

Code blocks like this https://github.com/coreos/tectonic-installer/blob/master/modules/aws/master-asg/master.tf#L92-L95 could be the source. But after looking at the TF code this invokes iam:GetRole. Maybe the OP hits edge cases enumerated here: https://www.terraform.io/docs/providers/aws/index.html#getting-the-account-id .

On Tue, Dec 12, 2017 at 4:13 PM, Ed Rooth notifications@github.com wrote:

@cpanato https://github.com/cpanato that's just the request to add it. Is there someplace recently that added that permission as a requirement?

Maybe @s-urbaniak https://github.com/s-urbaniak knows?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/coreos/tectonic-docs/pull/105#issuecomment-351080577, or mute the thread https://github.com/notifications/unsubscribe-auth/AAW8MEkHEvvbW3yut-9DkXq3IdeKFvsfks5s_pgagaJpZM4Q7PsT .

sym3tri commented 6 years ago

Figured it out with Carlos. It was an addition to the GUI backend.