search

coreos / tectonic-docs

Tectonic documentation - https://coreos.com/tectonic/docs/latest/
Apache License 2.0
42 stars 49 forks source link

Fix $PATH precedence #91

Closed mxinden closed 6 years ago

mxinden commented 6 years ago

In Unix systems, the $PATH is searched from the beginning to end. Thereby paths mentioned first take precedence over paths mentioned later. The shipped terraform binary should be choosen before a possible locally installed terraform binary. This patch makes sure, the shipped version takes precedence over any other possible local version.

@alexsomesan @squat Please correct me if I am wrong.

mxinden commented 6 years ago

@squat As far as I know editing $PATH invalidates the caches by default, right?

mxinden commented 6 years ago

Leaving the last review to @zbwright. Not sure, merging into master is the right process, or whether it should go somewhere else.

squat commented 6 years ago

@mxinden AFAIK it does not. if you spawn a new shell then normally $PATH is re-read. In any case, this is not needed for the docs, just reminiscing.

zbwright commented 6 years ago

Merging to master is the right process - my question to @joshix will be whether it should be back-ported to previous doc versions as well.