search

coreos / torus

Torus Distributed Storage
https://coreos.com/blog/torus-distributed-storage-by-coreos.html
Apache License 2.0
1.78k stars 172 forks source link

GobalMetadata doesn't return error #328

Closed kopiczko closed 7 years ago

kopiczko commented 8 years ago

All implementations of MetadataService.GlobalMetadata() never fail.

barakmich commented 8 years ago

Hm. This is a side-effect of the fact that, upon creation of a Metadata object, if it can't get the GMD, then it can't be created. This PR would canonicalize that statement.

I'm okay with this notion; if we add a comment to this effect on the interface.

kopiczko commented 8 years ago

I've added comment to the method and commit message. I tried to make that clear in as few words as possible.