search

coreos / torus

Torus Distributed Storage
https://coreos.com/blog/torus-distributed-storage-by-coreos.html
Apache License 2.0
1.77k stars 172 forks source link

cmux for now, proper https1.1/http2 later #36

Open barakmich opened 8 years ago

barakmich commented 8 years ago

Looks like this discussion is still happening: https://github.com/grpc/grpc-common/issues/284

(Tick marks to avoid linking the issue)

https://github.com/soheilhy/cmux is a reasonable workaround that exists today. Let's do it -- one port for HTTP API and internal gRPC. And when proper single-port support comes through grpc, then everyone wins.

philips commented 8 years ago

@barakmich etcd already implemented this, you can take a look: https://github.com/coreos/etcd/blob/66e5e4f298e66bdd72307336935e192aa66097c0/etcdmain/serve.go#L42