coreos / torus

Torus Distributed Storage
https://coreos.com/blog/torus-distributed-storage-by-coreos.html
Apache License 2.0
1.77k stars 172 forks source link

The default etcd address can't be parsed correctly on the latest golang version #444

Open freesky-edward opened 7 years ago

freesky-edward commented 7 years ago

I am not sure whether it is a bug of torus or golang itself. I file a bug here for deep discussion. my case when I run the cmd "torusctl init" with the newest go version, I got the following error message: start to init MDS... MDS init finished... invalid etcd address: parse 127.0.0.1:2379: first path segment in URL cannot contain colon root cause I found the golang community changed its url.Parse method after I research into the code. they think "127.0.0.1:2379" is no longer the correct address according to RFC 3986. it raises the error message from the "flagconfig.BuildConfigFromFlags" when parse the "defaultEtcdAddress" via url.Parse

mischief commented 7 years ago

try using http://127.0.0.1:2379

freesky-edward commented 7 years ago

yeah, it works well. should we change the defaultEtcdAddress value of flagconfig to "http://127.0.0.1:2379"?