coreos / zincati

Agent for Fedora CoreOS auto-updates
https://coreos.github.io/zincati
Apache License 2.0
153 stars 33 forks source link

cargo: update dependencies #1175

Closed HuijingHei closed 4 months ago

HuijingHei commented 5 months ago

CI failed

Should I update rust-version = "1.71.0" to rust-version = "1.74.0" in Cargo.toml?

jlebon commented 5 months ago

I think we can bump to 1.75.0. See https://github.com/coreos/coreos-installer/pull/1453.

HuijingHei commented 5 months ago

The failed log seems wired, run successfully locally, will look more about it.

jlebon commented 5 months ago

Possibly related to the zbus bump from 3.6 to 3.15. Odd that you can't reproduce it locally though. Are you sure that's with the same Cargo.lock?

HuijingHei commented 5 months ago

Possibly related to the zbus bump from 3.6 to 3.15. Odd that you can't reproduce it locally though. Are you sure that's with the same Cargo.lock?

I rebuild with override/rootfs, can reproduce the failed issue locally, thanks!

# busctl call org.coreos.zincati /org/coreos/zincati org.coreos.zincati.Experimental LastRefreshTime
Call failed: The name is not activatable
HuijingHei commented 5 months ago

Thanks @jlebon for the pointer, see https://github.com/coreos/zincati/pull/1119#issuecomment-1802558737 and https://github.com/coreos/zincati/pull/966, will skip zbus update

qemu0 kola-runext-test-experimental.sh[2136]: # Call failed: The name is not activatable

qemu0 kola-runext-test-experimental.sh[2129]: + fatal 'File '\''err.txt'\'' doesn'\''t match regexp '\''Access denied'\'''

qemu0 kola-runext-test-experimental.sh[2129]: + echo error: File ''\''err.txt'\''' 'doesn'\''t' match regexp ''\''Access' 'denied'\'''

qemu0 kola-runext-test-experimental.sh[2129]: error: File 'err.txt' doesn't match regexp 'Access denied'

qemu0 kola-runext-test-experimental.sh[2129]: + exit 1
HuijingHei commented 5 months ago

LGTM. Though we should try to get to the bottom of that zbus issue at some point. Would be nice if we could stop bundling in Fedora, and I this will likely be an issue.

Yes, will create an issue to track it.