coreruleset / documentation

CRS Documentation
https://coreruleset.org/docs/
4 stars 20 forks source link

feat: restructure; update naming pattern and weight; fix inner-link #137

Open dextermallo opened 4 months ago

dextermallo commented 4 months ago

Proposed changes

Implement #133

Further comments

(Some headers of page may be incorrect or be duplicated - I don't want to change them at the moment, just want to show the effects of re-order)

  • c701cdc
  • Restructure (based on #133)
  • Update naming pattern (to easier map between web and Markdown files)
  • Update weight accordingly.
  • Fix the inner links for the new structure.
fzipi commented 1 month ago

Hi @dextermallo ! Can you rebase your changes?

dextermallo commented 1 month ago

Hi @dextermallo ! Can you rebase your changes?

Done in https://github.com/coreruleset/documentation/pull/137/commits/0f7a7059b284c9a3b7777a2fa61433000b6002aa. Also fix an image-link error :)

dextermallo commented 2 weeks ago

Hmm not sure what bumped into my PR; every time I rebase, the PR reverts some of my previous changes. Perhaps I should wait until folks make a decision to move forward and then make changes one time. Otherwise I have to keep updating it... :(

(The conflicts I saw in the PR should not be existed since the files are renamed and moved)