coreruleset / documentation

CRS Documentation
https://coreruleset.org/docs/
4 stars 20 forks source link

feat(description): add files description in yaml #50

Closed fzipi closed 8 months ago

fzipi commented 2 years ago

Signed-off-by: Felipe Zipitria felipe.zipitria@owasp.org

Generate file description based on yaml content, not in the markdown file. Played with the idea of adding a general comment to the rules file itself, so it is even easier to maintain. But then I've failed to easily parse that from hugo. So here is my second best approach.

Now we need to add the relevant information on the yaml file only!

fzipi commented 2 years ago

@RedXanadu @dune73 What do you think about this approach?

theseion commented 2 years ago

Neat!

RedXanadu commented 2 years ago

Sorry @fzipi, I'll admit, I had a quick look when you submitted this the other week and I didn't understand it. I haven't had time to properly look into it yet. Apologies.

dune73 commented 2 years ago

I see more or less what you are doing here @fzipi. But I do not yet understand the motivation. Could you explain why we need this to be machine readable?

fzipi commented 2 years ago

To me, it's easier to maintain in a centralized place. Having multiple major versions might imply a headache on copy and pasting different files. Keeping the format also is a pain. This way you just write in one file and forget about the format.

Ideally, we could write the comment in the .conf file and parse it automagically to generate this content. But there is no easy way to do that.

fzipi commented 8 months ago

Any other comments here?

theseion commented 8 months ago

LGTM.

dune73 commented 8 months ago

Agreed