search

coreruleset / documentation

CRS Documentation
https://coreruleset.org/docs/
4 stars 20 forks source link

chore: update example tests in contribution docs #86

Closed theseion closed 1 year ago

theseion commented 1 year ago

Fixes #85

dune73 commented 1 year ago

Looks good to me. Anything to say before merging @RedXanadu?

RedXanadu commented 1 year ago

Thank you for sorting this @theseion! I've only just seen this.

One question: what is "uri: "/post""? That looks new to me, and I don't know what it is. We don't have that documented, as far as I can see.

theseion commented 1 year ago

httpbin has one dedicated endpoint for each HTTP method. Requests to / return status 200 but include a large HTML payload. Using the dedicated endpoints does not include any HTML and is thus preferable in terms of raw test throughput. Yes, that should be documented.

theseion commented 1 year ago

See #92.

dune73 commented 1 year ago

Thanks for explanation and doc PR.