fix: add lua modules to openresty

theseion commented 5 months ago

Oh, was this your question earlier, whether to use lua-rocks for OpenResty to install the modules? For the OpenResty image that may be the better option, TBH. I'd prefer all packages to come from the same source (in this case, all lua modules from the Lua package manager). But it probably doesn't make huge difference.

fzipi commented 5 months ago

Yes, exactly. That was my question. No worries, I'll change this one.

fzipi commented 5 months ago

Ouch, forgot that Debian an alpine have different package names.

fzipi commented 5 months ago

Well, I would love to see the maintainer @TafkaMax chiming on this in the future. We mentioned that we wouldn't maintain the image, and I think this was more work than expected for openresty.

git must be installed for luarocks to build lua-zlib. This pointed me to a problem in our alpine image, where the module lua-lzlib is different from lua-zlib, and it is unmaintained and the repo is archived.
then everything is built in the last layer. I think the alpine-fat might not make sense if there is one additional step building all the lua modules and then copying the results to the final image. My 2 cents.

👉 In the end, if there is no maintenance for this image, I would drop it. We don't need the additional work. 🤷

theseion commented 5 months ago

Agreed. Let's give them the benefit of the doubt for now ;)

coreruleset / modsecurity-crs-docker

fix: add lua modules to openresty #208