search

coreruleset / modsecurity-crs-docker

Official ModSecurity Docker + Core Rule Set (CRS) images
https://coreruleset.org
Apache License 2.0
269 stars 69 forks source link

Allow nginx resolver directive to be configured #75

Closed bguerout closed 2 years ago

bguerout commented 2 years ago

Add resolver directive in nginx.conf.template to allow 91-update-resolver.sh entrypoint from modsecurity-docker to patch value

fix #74

fzipi commented 2 years ago

Hey @bguerout! Taking a second look at the files... maybe we just need to remove the nginx.conf.template file. That way we use everything from upstream, and the DNS_SERVER is already there.

bguerout commented 2 years ago

The two templates are not exactly the same but if differences are not required, using the file from upstream is the better solution

fzipi commented 2 years ago

I would say update this PR to remove the file in this repo. We don't need the differences.

theseion commented 2 years ago

Made obsolete by #79.