search

coreruleset / nextcloud-rule-exclusions-plugin

Rule exclusion plugin for Nextcloud
Apache License 2.0
11 stars 7 forks source link

Exclusion rules for Nextcloud-Recognize module incomplete #100

Open browsingman opened 1 day ago

browsingman commented 1 day ago

Exclusions rules for Nextcloud-Recognize Rule is not working correctly. The recognise Modul allows renaming Photos to names instead of numbers.

The current rule works correctly if they are only addressed by numbers, but as soon as it is renamed to Names, the exclusion rule does not apply any more and the request is being blocked.

EsadCetiner commented 1 day ago

@browsingman I'm not sure if you mean something else, but do you mean renaming tagged faces within the photos app? That's the only false positive I can find relating to Photos and Recognize. If your having issues with something else could you provide detailed instructions on how to reproduce it or share your modsec audit log?

browsingman commented 14 hours ago

Yes sorry. I was a bit tired when writing this and English is not my native language. Of course I meant the topic if renaming tagged faces within the photos app. Do you already know what kind of fix could be used or when it will be fixed?

EsadCetiner commented 14 hours ago

@browsingman Thanks for confirming, I prepared an PR earlier and I've just opened it now #102

Let me know if it fixes your issue

browsingman commented 7 hours ago

So I applied the fix that you created manually and it does indeed fix the problem ... making me very happy ;-)