search

coreruleset / nextcloud-rule-exclusions-plugin

Rule exclusion plugin for Nextcloud
Apache License 2.0
11 stars 7 forks source link

Fix for few FPs #15

Closed Xhoenix closed 1 year ago

Xhoenix commented 1 year ago

As promised in my last PR, here are 10 more FPs. There are a few more FPs, but I forgot to label them as PL 1 and they got mixed with my PL 2 FPs. @theseion if you find a typo or mistake, kindly make changes where necessary. Thank you.

Also, we need to update the plugin version to 1.0.1, as done with WordPress plugin.

theseion commented 1 year ago

Thanks you very much! Yes, we will increase the version number.

Xhoenix commented 1 year ago

Thanks you very much! Yes, we will increase the version number.

I can increase it from my side. It's a simple sed command.

theseion commented 1 year ago

I can increase it from my side. It's a simple sed command.

No, I'd rather have a separate PR for that.

theseion commented 1 year ago

There's something wrong with the test setup. I need to investigate that before we can merge.

That reminds me: if you're up for it it would be nice to have your FP's covered by tests.

azurit commented 1 year ago

Guys, i would not change the version numbers yet. None of the plugins was officially released yet and there is no need for a version change. Let's wait until CRS 4.0 and then we will release all plugins under current versions (and also we will do a downloadable release here on github).

azurit commented 1 year ago

@Xhoenix Can you add yourself into the CONTRIBUTORS.md? Thanks.

theseion commented 1 year ago

@Xhoenix rule ID 9508602 is a duplicate, that's why the tests fail.

theseion commented 1 year ago

Thanks @Xhoenix. @azurit, I'll leave merging to you.

azurit commented 1 year ago

Merged, thanks to everyone!

azurit commented 1 year ago

Merged, thanks to everyone!