search

coreruleset / nextcloud-rule-exclusions-plugin

Rule exclusion plugin for Nextcloud
Apache License 2.0
11 stars 7 forks source link

Got a lot of FP with Nextcloud 26 #20

Closed prghix closed 9 months ago

prghix commented 1 year ago

So asking for comments :)

RedXanadu commented 1 year ago

Hi,

The same as with #21, please edit your opening comment to describe the change and its purpose, and please use an appropriate rule ID for your proposed new rule. Follow the rule ID pattern already established in the file. Thanks!

azurit commented 1 year ago

@prghix This is already fixed here: https://github.com/coreruleset/nextcloud-rule-exclusions-plugin/blob/25467b4f440295a9959d997868eda405a746b87a/plugins/nextcloud-rule-exclusions-before.conf#L129

prghix commented 1 year ago

@prghix This is already fixed here:

https://github.com/coreruleset/nextcloud-rule-exclusions-plugin/blob/25467b4f440295a9959d997868eda405a746b87a/plugins/nextcloud-rule-exclusions-before.conf#L129

I have my rules from April 7th... this commit was already included.

Looks like it wasnt enough, still got FPs.

I'll provide debug...

azurit commented 1 year ago

@prghix Any news? Thank you.

theseion commented 9 months ago

Closing this due to inactivity.