search

coreruleset / nextcloud-rule-exclusions-plugin

Rule exclusion plugin for Nextcloud
Apache License 2.0
11 stars 7 forks source link

fix: rules and tests after running at paranoia level 4 #61

Closed theseion closed 6 months ago

theseion commented 6 months ago

With the CRS v4 images, it has become apparent that plugin tests were being run at paranoia level 1. Now, they are running at paranoia level 4, revealing some mistakes in the tests and rules.

theseion commented 6 months ago

@EsadCetiner ready for review.

azurit commented 6 months ago

@theseion Why are you adding json and also non-json variants of arguments everywhere?

theseion commented 6 months ago

In v2, JSON variables are not prefixed with json. So, for v2: ARGS:sessionToken, for v3: ARGS:json:sessionToken.

EsadCetiner commented 6 months ago

@theseion Thank you for cleaning all of this up!