coreruleset / nextcloud-rule-exclusions-plugin

Rule exclusion plugin for Nextcloud
Apache License 2.0
11 stars 7 forks source link

fix: fp regression with xml content #72

Closed EsadCetiner closed 3 months ago

EsadCetiner commented 3 months ago

A previous pull request removed XPath XML, this has caused a regression with XML content and introduced some new false positives. This PR reverts those changes

theseion commented 3 months ago

This is the PR that made that change: #66. Are you sure your PR will not break CalDav support?

EsadCetiner commented 3 months ago

@theseion It's already broken, that specific change was a suggestion to improve performance.