coreruleset / nextcloud-rule-exclusions-plugin

Rule exclusion plugin for Nextcloud
Apache License 2.0
11 stars 7 forks source link

refactor: overhaul and cleanup rule exclusions for settings #86

Closed EsadCetiner closed 1 month ago

EsadCetiner commented 1 month ago

Over the past year the Nextcloud plugin has grown dramatically in size with improved coverage and support for various features within Nextcloud, this has come at the expense of code readability and maintainability. Rule IDs have grown from 53 to 185 and the lines of code from 780 to 2756.

This PR is focused on overhauling personal/administration settings and has:

The Nextcloud plugin will likely remain large since Nextcloud incredibly feature rich, but it's a start.

EsadCetiner commented 1 month ago

@theseion I didn't really touch any of the functionality of the rules. they largely work the same. It's just a reorganization/cleanup and simplifying