coreshop / CoreShop

CoreShop - Pimcore enhanced eCommerce
http://www.coreshop.org
Other
277 stars 157 forks source link

Free shipping option won't get applied #2308

Open valentin- opened 1 year ago

valentin- commented 1 year ago
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

Hi, I'm not sure if it's related to this ticket: https://github.com/coreshop/CoreShop/issues/2178

Currently there are 2 carrier options available when the total price is 0.

image

I want to select Gratisversand, but Selbstabholung is selected on the summary page.

image

It looks like the check fails at: https://github.com/coreshop/CoreShop/blob/935178b6b25cfb38a7bbd658dc5f9d3b585dbd84/src/CoreShop/Component/Core/Order/Processor/CartShippingProcessor.php#L86

This rule is applied for the carrier Gratisversand:

image

Thanks!

dpfaffenbauer commented 8 months ago

@valentin- is this still a issue?

valentin- commented 8 months ago

Hi @dpfaffenbauer I've udpated Coreshop from 3.0.6 to 3.2.0 - the error still occurs.

I also ran into a new issue. When selecting the default payment option (paid) a SQL error occurs. I executed the migrations, and the fields are present - but probably mismatch?

image

image

dpfaffenbauer commented 8 months ago

@valentin- that is a problem with a dependency of CoreShop, see https://github.com/coreshop/CoreShop/issues/865

Re Main Topic of this issue, can you describe again what the Problem is? I cannot really follow your it

valentin- commented 8 months ago

@dpfaffenbauer there are 2 shipping rules available:

When I pick Gratisversand the summary shows Selbstabholung as selected delivery rule. I think Selbstabholung is applied as the validation for Gratisversand fails in the isCarrierValid() check.

dpfaffenbauer commented 2 weeks ago

@valentin- Long time no see, sorry, but does this still happen for you?