Discount Total with Shipping

coreshop / CoreShop

CoreShop - Pimcore enhanced eCommerce

http://www.coreshop.org

Other

275 stars 157 forks source link

Discount Total with Shipping #2503

Open solverat opened 9 months ago

solverat commented 9 months ago

Q	A
Bug report?	not sure
Feature request?	no
BC Break report?	no
RFC?	yes/no

Add a product with price of 200
Add voucher cart rule with action Discount Amount:

Total stays at 10 (Shipping costs):

Since I've selected Total in Apply On, I'm expecting a total of 0.

dpfaffenbauer commented 9 months ago

@solverat might this be a priority issue? so the discount is calculated before the shipping is? what happens if you click update cart again?

solverat commented 9 months ago

what happens if you click update cart again?

Unfortunately, it stays the same.

dpfaffenbauer commented 9 months ago

Fortunately ;) that is good news, so we know nothing shady is going on. I have to debug this to figure it out

dpfaffenbauer commented 1 month ago

@solverat I took some time, but I debugged it today. The "Apply On" actually doesn't work anymore since we introduced applying the discounts to the items with item ajdustments. this is intentional for vat reasons. if we have discounts, we have apply them to the items to re-calculate the vat. If we apply more then the cart is worth, we only use as much as possible from the subtotal (subtotal being the total of all items). other adjustments like shipping are not affected, since this only get's applied to items.

My suggested solution: remove the "Apply On" option since it doesn't make sense and doesn't work.