Cart Rules: Solidify Cart Calculation

[solverat]

• [x] If discount is bigger than cart amount, the final cart amount should be 0.00.
• [x] If cart amount is 0.00, the PG should be changed to offline.

[dpfaffenbauer]

done here: https://github.com/coreshop/CoreShop/pull/263

can you review please?

[solverat]

@dpfaffenbauer reviewed and merged! Only thing: discount should also respect shipping / payment fees etc!

[dpfaffenbauer]

should be working now, can you review again please?

[solverat]

@dpfaffenbauer if discount is greater than the cart amount, the negative price difference will show up as a positive total.

• product: 100,-
• voucher: 150,- total: 50,-

[solverat]

and also: if payment is empty in cart/order object, do we have some side effects we need to handle? (like paymentprovider is null in twig)

[dpfaffenbauer]

Regarding payment: now, thats optional.

[solverat]

i just tested the negative case: works now. so hopefully this is fixed...