search

coreshop / CoreShop

CoreShop - Pimcore enhanced eCommerce
http://www.coreshop.org
Other
274 stars 154 forks source link

make password reset notification store aware #2609

Closed hethehe closed 2 months ago

hethehe commented 2 months ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets none

There is an error if you use the password reset notification with store based emails. Message with ID "62164" of Class "CoreShop\Component\Notification\Messenger\NotificationMessage" failed. Redelivery tried at "2024-04-19 11:47:40". Error was: "StoreMailActionProcessor: Store is not set." => That's because the Customer is not an instance of StoreAwareInterface.

With this PR the store_id is added to the rules parameters.

dpfaffenbauer commented 2 months ago

something is breaking the behat tests, I am pretty certain its not your change. I will check next week

dpfaffenbauer commented 2 months ago

reason this fails is this: https://github.com/coreshop/CoreShop/pull/2612. Your PR is fine, thanks @hethehe