reimplement existing data check in ProductQuantityPriceRulesCloner - Githubissues

coreshop / CoreShop

CoreShop - Pimcore enhanced eCommerce

http://www.coreshop.org

Other

274 stars 154 forks source link

reimplement existing data check in ProductQuantityPriceRulesCloner #2620

Closed solverat closed 2 months ago

solverat commented 2 months ago

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	yes/no
Fixed tickets	--

[!CAUTION] This also needs to be fixed in 4.0!

This PR fixes the existing data check in ProductQuantityPriceRulesCloner which has been removed in 3.x here:

https://github.com/coreshop/CoreShop/commit/b6398adba4e8ff3c5832254776882eb89aa08654#diff-e962d096cbcf710b879a82241a724d669b979581a20b9ed4d828823620fa09cfL41

Otherwise, all defined quantity price rules in variants will be overwritten after dispatching this action:

dpfaffenbauer commented 2 months ago

@solverat thanks and merged to 4.x