search

coreshop / CoreShop

CoreShop - Pimcore enhanced eCommerce
http://www.coreshop.org
Other
275 stars 157 forks source link

fix token resolver service #2643

Closed solverat closed 4 months ago

solverat commented 4 months ago
Q A
Bug fix? yes
New feature? yes/no
BC breaks? no
Deprecations? yes/no
Fixed tickets #2642
sonarcloud[bot] commented 4 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

dpfaffenbauer commented 4 months ago

I'll further review this so the tests break when this happens in the future

dpfaffenbauer commented 4 months ago

@solverat CoreShop 3.2 is Pimcore 10 only, that service is available there: https://github.com/pimcore/pimcore/blob/v10.6.9/lib/Security/User/TokenStorageUserResolver.php

It also exists in the Pimcore 11.2 branch for CoreShop 4.x: https://github.com/pimcore/pimcore/blob/11.2/lib/Security/User/TokenStorageUserResolver.php

dpfaffenbauer commented 4 months ago

@solverat could it be that you are running pimcore 10.5?

solverat commented 4 months ago

god damnit, yes. We're on 10.5.25 on some projects. since this is a really stable version, we skipped the "deprecation release".

dpfaffenbauer commented 4 months ago

@solverat see: https://github.com/coreshop/CoreShop/pull/2644

we are only testing against 10.6 and therefore can only guarantee to be compatible with that. therefore we upgrade the dependencies to 10.6 only.

dpfaffenbauer commented 4 months ago

god damnit, yes. We're on 10.5.25 on some projects. since this is a really stable version, we skipped the "deprecation release".

10.6.9 is also stable ;)