search

coreshop / CoreShop

CoreShop - Pimcore enhanced eCommerce
http://www.coreshop.org
Other
277 stars 157 forks source link

Order Payment Total - wrong formatting when using different decimal factor #2699

Closed MatejaPodravac closed 2 months ago

MatejaPodravac commented 2 months ago
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

On the order overview page in Pimcore backend in the summary section order payment total is not displayed correctly. For example, total is 44€ and payment total stored is 4400.

Configuration for fraction digits:

core_shop_currency:
    money_decimal_precision: 2
    money_decimal_factor: 10000

coreshop.util.format.currency relies completely on the defined decimal factor which results in payment total not being displayed correctly. Instead of defined decimal factor, it should rely on the factor passed from OrderController getSummary for every summary item. Only if it's not passed use defined fraction digits.

image image

MatejaPodravac commented 2 months ago

@dpfaffenbauer do you plan to include this fix in the 4.0.10 release?

dpfaffenbauer commented 2 months ago

@MatejaPodravac it is, every change in 3.2.x gets merged up to 4.0.x and next