search

coreshop / CoreShop

CoreShop - Pimcore enhanced eCommerce
http://www.coreshop.org
Other
277 stars 157 forks source link

use getCount() instead of getTotalCount() for BatchListing #2715

Closed hethehe closed 2 months ago

hethehe commented 2 months ago
Q A
Bug fix? yes
New feature? no
BC breaks? no (maybe if BatchListing was used wrongly)
Deprecations? no
Fixed tickets #2714

use getCount() instead of getTotalCount() for BatchListing because getTotalCount ignores limit and offset.

github-actions[bot] commented 2 months ago

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

dpfaffenbauer commented 2 months ago

@hethehe the feature is only partly tested in index generation. can you add another test? please also sign the cla (we changed the CLA workflow and it has to be resigned now)

hethehe commented 2 months ago

Busy day yesterday... I really like the BEHAT approach, but I'm not used to using it and unfortunately currently don't have the time to dive into.

hethehe commented 2 months ago

I have read the CLA Document and I hereby sign the CLA

dpfaffenbauer commented 2 months ago

@hethehe ok, I'll check then

dpfaffenbauer commented 2 months ago

@hethehe tests added

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dpfaffenbauer commented 2 months ago

@hethehe many thanks :)