coreshop / CoreShop

CoreShop - Pimcore enhanced eCommerce
http://www.coreshop.org
Other
275 stars 157 forks source link

Login throws error if customergroup is set #376

Closed Cruiser13 closed 6 years ago

Cruiser13 commented 6 years ago
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

If you create a customer group and set it to a customer, the customer can no longer login. It'll throw an error $roles must be an array of strings

coreshop-customergroups

solverat commented 6 years ago

There is also a deprecation we should get rid of: https://github.com/coreshop/CoreShop/blob/355234beb1118ba78491588435d62e5044c5156f/src/CoreShop/Bundle/CoreBundle/Resources/config/app/security.yml#L16

this value should be true. Therefor the customer needs to implement the EquatableInterface interface with the isEqualTo method:

# pimcore core example
public function isEqualTo(UserInterface $user)
{
      return $user instanceof self && $user->getId() === $this->getId();
}

keep in mind:

dpfaffenbauer commented 6 years ago

@Cruiser13 this is fixed now.

dpfaffenbauer commented 6 years ago

@solverat the deprecation should be fixed as well.

Cruiser13 commented 6 years ago

Thanks!