coreshop / CoreShop

CoreShop - Pimcore enhanced eCommerce
http://www.coreshop.org
Other
275 stars 157 forks source link

Backend Order Creation does not save language #398

Closed Cruiser13 closed 6 years ago

Cruiser13 commented 6 years ago
Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

Steps to reproduce: Create a new order and set a different language, german for example: order-german It'll not be saved and the default language will be assigned to the order: order-english

This leads to invoices in the wrong language and further issues.

I believe that language is not properly assigned here: https://github.com/coreshop/CoreShop/blob/3b63bec32bad078aaab24d61f04f45ba0baa7d71/src/CoreShop/Bundle/OrderBundle/Controller/AbstractSaleCreationController.php#L303 It's being saved before as far as I could debug this: https://github.com/coreshop/CoreShop/blob/3b63bec32bad078aaab24d61f04f45ba0baa7d71/src/CoreShop/Bundle/OrderBundle/Controller/AbstractSaleCreationController.php#L234

dpfaffenbauer commented 6 years ago

this commit should fix it: https://github.com/coreshop/CoreShop/commit/d825a2d03f77632da38be14d905487fe24bafdf5

What it changes:

dpfaffenbauer commented 6 years ago

this is fixed now