search

corestario / tendermint

Tendermint with an embedded BLS random beacon
Other
18 stars 6 forks source link

Chose type of key for signing messages #66

Closed b00ris closed 5 years ago

b00ris commented 5 years ago

Problem

We don't understand well which type of key should we use for signing dkg messages The current implementation uses a key from the first part of dkg which is incorrect.

Acceptance Criteria

A comment here which justifies which key we should use and why.

related to: https://github.com/dgamingfoundation/tendermint/issues/64 https://github.com/dgamingfoundation/tendermint/pull/65

pr0n00gler commented 5 years ago

Well, after a little review of code, I think we should use validator's key for signing DKG messages. It's the same key which uses for signing vote messages

vshvsh commented 5 years ago

Does node that is not a validator have a validator key?

b00ris commented 5 years ago

@programmer10110 Is it the same key that we need to use for validators stacking or slashing in cosmos.sdk

zavgorodnii commented 5 years ago

We need to use the key that is used to sign votes.