search

coreui / coreui-free-vue-admin-template

Open source admin template based on Bootstrap 5 and Vue 3
https://coreui.io/product/free-vue-admin-template/
MIT License
3.28k stars 963 forks source link

feat: dont load package.json file directly into vue components. #267

Closed ppfeiler closed 2 years ago

ppfeiler commented 2 years ago

It is bad practice to load the package.json file directly into your codebase. Instead extract needed values as ENVs and use them. As this project is also in use by newbies, I thought that this change is neccessary so that they dont adapt these practice to their projects.

PS.: The link to the docs is also false, I corrected it. You can see that here. The link for the accordion docs refers to "undefined".

github-actions[bot] commented 2 years ago

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions