search

coreui / coreui-icons

CoreUI Free Icons - Premium designed free icon set with marks in SVG, Webfont and raster formats
https://coreui.io/icons/
Other
2k stars 155 forks source link

Default icon path to icon files in SCSS is wrong (Free icons) #20

Open jaydiablo opened 4 years ago

jaydiablo commented 4 years ago

Ran into this yesterday when trying to build these icons. The SASS transpilation step fails because the path defined for the Icon files here: https://github.com/coreui/coreui-icons/blob/master/scss/free/_variables.scss#L2 is incorrect. The fonts folder is actually one more level back, so this:

$coreui-icons-font-path: "../fonts" !default;

should be

$coreui-icons-font-path: "../../fonts" !default;

Here's the error I was receiving:

Syntax Error: ModuleNotFoundError: Module not found: Error: Can't resolve '../fonts/CoreUI-Icons-Free.eot' in '/project/node_modules/@coreui/icons/scss/free'

mrholek commented 3 years ago

@jaydiablo I fixed it in the latest release, can you check if this release is ok?

berkut1 commented 3 years ago

@mrholek I have got the similar error in 2.0.0-beta.5 and 2.0.0-rc.0

Syntax Error: ModuleNotFoundError: Module not found: Error: Can't resolve '../../node_modules/@coreui/icons/scss/fonts/CoreUI-Icons-Free.eot' in '/app/assets/css'

This helps me: $coreui-icons-font-path: "../../fonts" !default;

EstelleH commented 3 years ago

@mrholek I have the same issue with @coreui/icons@^2.0.1 version.

doelmi commented 11 months ago

In Laravel vite, I add $coreui-icons-font-path: "@coreui/icons/fonts" !default; in app.scss file. It works.