search

coreui / coreui-icons

CoreUI Free Icons - Premium designed free icon set with marks in SVG, Webfont and raster formats
https://coreui.io/icons/
Other
1.97k stars 153 forks source link

Include path for SVG files in Flag icons is incorrect #22

Open jaydiablo opened 4 years ago

jaydiablo commented 4 years ago

This is similar to #20 but for the Flag icons.

The path defined here: https://github.com/coreui/coreui-icons/blob/master/scss/flag/_core.scss#L14 isn't quite right because the svg folder is actually one level deeper. This error was emitted when transpiling the SCSS:

Syntax Error: ModuleNotFoundError: Module not found: Error: Can't resolve '../svg/flag/cif-ad.svg' in '/project/node_modules/@coreui/icons/scss/flag'

To fix this, I changed this line:

background-image: url(../svg/flag/#{$coreui-icons-prefix}#{$icon}.svg);

to

background-image: url(../../svg/flag/#{$coreui-icons-prefix}#{$icon}.svg);

patdec commented 3 years ago

Same issue for CoreUI Icons PRO. Can you fix it. Please

mrholek commented 3 years ago

Sure, I will check it ASAP

Letrab commented 3 years ago

@mrholek , any update on fixing this (in PRO)? Thanks!

mrholek commented 3 years ago

@jaydiablo @patdec I fixed it in the latest release, can you check if this release is ok?

patdec commented 3 years ago

@mrholek release 2.0.0-rc.0 isn't accessible from npm registry: https://registry.npmjs.org/@coreui/icons-pro/

linkuha commented 3 years ago

@mrholek when will be update in npm ? cloning from git is not a suitable option (also spending a lot of disk space)