search

coreui / coreui-icons

CoreUI Free Icons - Premium designed free icon set with marks in SVG, Webfont and raster formats
https://coreui.io/icons/
Other
2k stars 154 forks source link

Should font paths be relative to package? #30

Open cballenar opened 4 years ago

cballenar commented 4 years ago

Description: I recently pulled coreui and coreui icons to a Laravel setup and when attempting to run npm build, NPM was not able to trace the .eot file to the right location because it was using ../ as seen in:

https://github.com/coreui/coreui-icons/blob/b9bb76bdec67609bb5948ba6abcd6400413389da/scss/free/_variables.scss#L2

Experiment: I tested replacing ../ with ~@coreui/icons/ and this did the trick. NPM was able to build the proper files and I'm now able to load the icons in the page.

Could/Should this be corrected in font related files or should I be working with these packages differently? 🧐

Thanks,

e-repo commented 4 years ago

I faced the same problem! Perhaps assign variable $coreui-icons-font-path to a another value

$coreui-icons-font-path: "../../fonts" !default;