search

corewar / corewar-ui

HTML5 & javascript implementation of the classic game Corewar
MIT License
13 stars 2 forks source link

add fast-json-stable-stringify dependency #289

Closed jwasinger closed 6 years ago

jwasinger commented 6 years ago

This was missing from package.json and broke npm i for me.

dougajmcdonald commented 6 years ago

Hi @jwasinger thanks for the PR, I don't think either me or @gareththegeek noticed the same issue when installing but I'll take a gander now.

dougajmcdonald commented 6 years ago

Hmm, @jwasinger I'm not seeing any error when deleting everything, pulling from master and npm iing followed by npm start.

What OS / node / npm version etc are you running on?

I'm on Win10 with Node 8.11.3 with npm 5.6.0

jwasinger commented 6 years ago

I was on Ubuntu 17.04. Tried it locally on my mac and I didn't get the error. I will try again on linux and see if I can recreate again.

dougajmcdonald commented 6 years ago

Hi @jwasinger, I'm going to close this one for the time being. please re-open if you see it again on linux or any other OS and we'll take a gander.

Cheers,

Doug