search

corey-hammerton / puppet-metricbeat

Apache License 2.0
2 stars 32 forks source link

Option to set metricbeat.config.modules.path #14

Open trenta opened 5 years ago

trenta commented 5 years ago

At the moment I can't find a way to set the metricbeat.config.modules.path option in metricbeat.yml and the recommended way to use modules now it so have the settings in the modules.d directory. Adding this option would be handy.

cdenneen commented 5 years ago

So right now the modules array supplies the module config. Not sure why @corey-hammerton is creating modules.d files. It's one or other. @corey-hammerton How do you want this module to handle? By using @sfuerte hardcoded files it limits modifications. These should be templates.

sfuerte commented 5 years ago

@cdenneen, yes, templates is a proper way to do it. The current "files" implementation is just a quick and dirty fix to get them installed and enabled. Those files/modules come with standard Debian package. Simply didn't have time to do them in proper way via templates.

cdenneen commented 5 years ago

@sfuerte Thanks. Definitely works but not for any add/remove/updates going forward with new releases. Would you have the time to help implement templates for these?

sfuerte commented 5 years ago

@cdenneen, will see if I have time for that. On the another hand, had a conversation with sales guys from ES last week or so. Asked them a question why they don't provide official modules for Puppet to support file/metric/other beats. That would be very logical on their end to do that for most common orchestration systems (Puppet, Chef, Ansible, Terraform). Will ping them again, hopefully they can dedicate someone to do that.

cdenneen commented 5 years ago

Would be nice but believe it's due to limited "puppet" people at ES. @tylerjl is only 1 person ;)

sfuerte commented 5 years ago

I know, it's weird. I asked the sales guys about Puppet support, the answer was: "we do support Elastic there". Which is weird, given the proportion in environments and the worst comes to worst, ES itself can be installed manually. But for fully automated monitoring, one definitely doesn't want to install Beats manually.