search

coreybutler / node-windows

Windows support for Node.JS scripts (daemons, eventlog, UAC, etc).
Other
2.79k stars 358 forks source link

Feature/allow command arguments #239

Closed julianhille closed 1 year ago

julianhille commented 5 years ago

Add possibility to add arguments to the script to be called

jdziat commented 5 years ago

Thanks for the PR,

I believe the intention is to keep the api calls identical across the three OS packages though. Any additional configuration or specific functionality should be left to to the developer to add via a wrapper or some other means.

julianhille commented 5 years ago

That is why I added a pr to add arguments for all the three packages.

jdziat commented 5 years ago

My apologies should of checked the PRs on those. So we need consensus across all three repos.

Also can you provide use cases where a flags property would benefit over the methods I purposed. The only one I can think of is modifying the service outside of these packages. However it is very early for me so I may not be thinking clearly.

julianhille commented 5 years ago

I've got a single app compiled / packaged which needs some command line args to start as a service.