coreybutler / node-windows

Windows support for Node.JS scripts (daemons, eventlog, UAC, etc).
Other
2.83k stars 356 forks source link

Fix - Replace \r and \n with the accepted return line character #241

Closed demitchell14 closed 4 years ago

demitchell14 commented 5 years ago

A simple 1 line fix to allow for \r, \n, \r\n, and \n\r all to be converted into \f, the accepted Return Line character for the Event Viewer.

As said in the Issue I asked about for this, #240, This will result in the XML data to be malformed for some reason. So with this, you won't be able to view extended details or the raw XML. However, considering the only actual implementation I see for this, is just sending a message, I personally don't see a problem with this. If you believe this could be a potential issue, I can go back through and make it an optional feature?