search

coreybutler / node-windows

Windows support for Node.JS scripts (daemons, eventlog, UAC, etc).
Other
2.83k stars 356 forks source link

Replace optimist with yargs #263

Closed samfundev closed 3 years ago

samfundev commented 4 years ago

optimist is deprecated and depends on an insecure version of a minimist.

forty commented 4 years ago

I would recommend using minimist directly instead. yargs has a shitload of dependencies: 27 total (including indirect ones) https://npm.anvaka.com/#!/view/2d/yargs Compare that with node-version which has only 4 :)

coreybutler commented 4 years ago

@forty I'll likely use https://github.com/author/arg, which I wrote myself and has zero dependencies. If I can't get to it soon, I'll merge this, just to eliminate the insecure version of minimist.

forty commented 4 years ago

I opened this PR https://github.com/coreybutler/node-windows/pull/267 to do that

samfundev commented 4 years ago

I'll keep this open in case @coreybutler would want to merge this one in the mean time. If the other one gets merged then I'll close this one.

coreybutler commented 3 years ago

Closing in favor of #267.

seidhkona commented 2 years ago

Will #267 ever be merged?