Remove optimist in favor of @author.io/arg

coreybutler / node-windows

Windows support for Node.JS scripts (daemons, eventlog, UAC, etc).

Other

2.78k stars 357 forks source link

Remove optimist in favor of @author.io/arg #267

Closed forty closed 2 years ago

forty commented 3 years ago

This avoids a security issue on minimist, which is an indirect dependency

forty commented 3 years ago

Disclaimer: this was all done manually and I haven't tested anything :) please review with great care

aksswami commented 2 years ago

@coreybutler possible to merge this anytime soon?

JyotsnaC commented 2 years ago

Looking for the same. Issue to be resolved.

DFG-kjtroll commented 2 years ago

Looking to deploy my express API with this, and my infrastructure guys will love to see a clean npm audit before global install... my current workaround is to force it to use minimist 0.2.1 using npm-force-resolutions. But that only patches a project install of node-windows and I'm not sure if it introduces bugs... Would love to see this merged!