coreybutler / node-windows

Windows support for Node.JS scripts (daemons, eventlog, UAC, etc).
Other
2.78k stars 357 forks source link

Upgrade WinSW to 2.0.1 #268

Open nxtn opened 3 years ago

nxtn commented 3 years ago

WinSW 2 carries a logging framework so the binary is a bit larger.

Also removes .NET 2 support. Who is using .NET 2 these days?

Fixes #47


Bug fixes

Compatibility notes

coreybutler commented 3 years ago

I'll consider this, depending on how much time I get. I've been working on an alternative to winsw, so this may not be necessary.

nxtn commented 3 years ago

We're now building WinSW 3, and it's surprising to see this project is still using WinSW 1. A large number of issues in this repo have been resolved in the upstream.

I've been working on an alternative to winsw

Why reinvent the wheel? Is it written in Golang?

coreybutler commented 3 years ago

Yes, alternative is in Go. It's not recreating the wheel for me, because I'm building it for another effort.

Again, not opposed to merging this, I just need to test it/confirm and make sure I can continue to support it.

nxtn commented 3 years ago

Sounds good. I'm also considering rewriting WinSW in a different language, but I don't regard Go as a competitive choice. I would prefer a native language like Rust this time.

udany commented 3 years ago

Would this also address issue #53 and allow node-windows to set a StartupType?

nxtn commented 3 years ago

Would this also address issue #53 and allow node-windows to set a StartupType?

Yeah. There may be more ancient issues fixed