search

coreybutler / node-windows

Windows support for Node.JS scripts (daemons, eventlog, UAC, etc).
Other
2.83k stars 356 forks source link

[11/11/22]: [Register with windows restart manager] #327

Open DevRCRun opened 2 years ago

DevRCRun commented 2 years ago

Is your feature request related to a problem? Please describe. The nodejs installer on windows appears to be inconsistent version to version in whether it will proceed while node-windows originated services are running. On some versions it goes through fine, and the services (or machine) can then be restarted to pick up the new version, on others it errors out with "RESTART MANAGER: Failed to shut down all applications in the service's session"

Describe the solution you'd like My supposition is this is occurring because nodejs is in use / the services are not registered with windows restart manager https://learn.microsoft.com/en-us/windows/win32/rstmgr/about-restart-manager https://www.advancedinstaller.com/user-guide/qa-vista-restart-manager.html (I could be completely wrong about this and something else is at fault).

Describe alternatives you've considered Some hideous powershell scripted solution.

Additional context It would be useful to know if any other node-windows users experience the same problem (if not I'm likely way off track with what the issue actually is). I'm aware that the issue, if indeed that's what it is, may need to actually be addressed in winsw, but I'm aware that you're thinking of switching away from winsw, so thought it worth posting here. That's also why I've gone for a feature request. If this is invalid, happy to close as such!

Thanks

Please use the reactions to cast a vote in favor of or against this feature suggestion »
coreybutler commented 1 year ago

Marking as an enhancement request so I can address it (or at least test it) in the next version.