search

coreybutler / nvm-windows

A node.js version management utility for Windows. Ironically written in Go.
MIT License
37.28k stars 3.32k forks source link

[Bug/Feature?]: pnpm leaves files in nodejs install dir, breaking nvm install #1093

Open avelican opened 8 months ago

avelican commented 8 months ago

Description of the new feature / enhancement

Not sure if this is a bug or feature, but I had trouble installing nvm despite uninstalling npm because I forgot I had pnpm installed too, and it left a bunch of crap in C:\Program Files\nodejs folder. So the symlink failed and I was perplexed by nvm use not doing anything...

Suggestion: update readme to mention pnpm?

Suggestion: installer should warn about this? (nodejs existing causing symlink to fail)

Anyway, manually deleting nodejs install folder fixed this. (That's probably not how you should uninstall pnpm, but that's a problem for future me...)

Scenario when this would be used?

Upon installing, so the install actually works...

Supporting information

No response

coreybutler commented 8 months ago

Well that is perplexing. Thank you for bringing it to my attention. I'm not sure if this is something we want to tackle in NVM4W, based on the premise that supporting a non-official package manager sets a precedent for supporting them all. I agree that a warning would be nice, but this might need to be something that's a part of the debug feature. I'll give it some thought.

That said, we did put together a plan for some degree of support around different package managers in Runtime, so that is likely where this will ultimately be resolved. I'll keep this issue open and mark it with help wanted to keep the discussion going.